Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: patch more process properties during pre-execution #26517

Closed
wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

process: delay process.argv[0] and process.argv0 handling

Since these depends on process runtime states, delay them until
pre-execution.

process: create legacy process properties during pre-execution

Shim legacy process object properties of CLI options during
pre-execution instead of serializing them during bootstrap.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Since these depends on process runtime states, delay them until
pre-execution.
Shim legacy process object properties of CLI options during
pre-execution instead of serializing them during bootstrap.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 8, 2019
@joyeecheung
Copy link
Member Author

lib/internal/bootstrap/pre_execution.js Outdated Show resolved Hide resolved
src/node_process_object.cc Show resolved Hide resolved
@joyeecheung
Copy link
Member Author

@joyeecheung
Copy link
Member Author

Landed in eb0bf8d...0a95c87

joyeecheung added a commit that referenced this pull request Mar 12, 2019
Since these depends on process runtime states, delay them until
pre-execution.

PR-URL: #26517
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung added a commit that referenced this pull request Mar 12, 2019
Shim legacy process object properties of CLI options during
pre-execution instead of serializing them during bootstrap.

PR-URL: #26517
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly.

@refack refack assigned refack and unassigned refack Mar 14, 2019
targos pushed a commit that referenced this pull request Mar 28, 2019
Since these depends on process runtime states, delay them until
pre-execution.

PR-URL: #26517
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 28, 2019
Shim legacy process object properties of CLI options during
pre-execution instead of serializing them during bootstrap.

PR-URL: #26517
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 30, 2019
Since these depends on process runtime states, delay them until
pre-execution.

PR-URL: #26517
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 30, 2019
Shim legacy process object properties of CLI options during
pre-execution instead of serializing them during bootstrap.

PR-URL: #26517
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants